Bug 74162 – Implement CSS resize property in CSSStyleApplyProperty.

• Component: New Bugs
• Status: RESOLVED FIXED

[Luke Macpherson]

Implement CSS resize property in CSSStyleApplyProperty.

[Luke Macpherson]

Created attachment 118528 [details]
Patch

[Julien Chaffraix]

Comment on attachment 118528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160
> +        if (!primitiveValue->getIdent())
> +            return;
> +
> +        EResize r = RESIZE_NONE;
> +        switch (primitiveValue->getIdent()) {
> +        case 0:
> +            return;

This was not in the original code. It also looks like it is doing exactly the check above so it should be removed.

[Luke Macpherson]

Comment on attachment 118528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review

>> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160
>> +            return;
> 
> This was not in the original code. It also looks like it is doing exactly the check above so it should be removed.

Indeed. I moved it into the switch to avoid the overhead of calling the getter (which actually does some work) multiple times, but evidently forgot to remove the existing check. Thanks for spotting this.

[Luke Macpherson]

Created attachment 118714 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 118714 [details]
Patch for landing

Clearing flags on attachment: 118714

Committed r102544: <http://trac.webkit.org/changeset/102544>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.