| Summary: | Implement CSS resize property in CSSStyleApplyProperty. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Luke Macpherson <macpherson> | ||||||
| Component: | New Bugs | Assignee: | Luke Macpherson <macpherson> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Luke Macpherson
2011-12-08 21:01:35 PST
Created attachment 118528 [details]
Patch
Comment on attachment 118528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review > Source/WebCore/css/CSSStyleApplyProperty.cpp:1160 > + if (!primitiveValue->getIdent()) > + return; > + > + EResize r = RESIZE_NONE; > + switch (primitiveValue->getIdent()) { > + case 0: > + return; This was not in the original code. It also looks like it is doing exactly the check above so it should be removed. Comment on attachment 118528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118528&action=review >> Source/WebCore/css/CSSStyleApplyProperty.cpp:1160 >> + return; > > This was not in the original code. It also looks like it is doing exactly the check above so it should be removed. Indeed. I moved it into the switch to avoid the overhead of calling the getter (which actually does some work) multiple times, but evidently forgot to remove the existing check. Thanks for spotting this. Created attachment 118714 [details]
Patch for landing
Comment on attachment 118714 [details] Patch for landing Clearing flags on attachment: 118714 Committed r102544: <http://trac.webkit.org/changeset/102544> All reviewed patches have been landed. Closing bug. |