Bug 74130

Summary: Accessibility object searching layout tests are incomplete.
Product: WebKit Reporter: Samuel White <samuel.white>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Adds support for visited link searching.
none
Added link verification. none

Samuel White
Reported 2011-12-08 14:41:01 PST
Unless plans exist to deprecate the layout tests in platform/mac/accessibility/search-predicate.html the remaining tests should be implemented.
Attachments
Adds support for visited link searching. (3.59 KB, patch)
2011-12-08 15:20 PST, Samuel White 		no flags
DetailsFormatted DiffDiff
Added link verification. (23.37 KB, patch)
2011-12-08 16:32 PST, Samuel White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Samuel White
Comment 1 2011-12-08 15:20:02 PST
Created attachment 118478 [details] Adds support for visited link searching. Also, removed unimplemented frames searching as it covered by tests in platform/mac/accessibility/search-with-frames.html.
chris fleizach
Comment 2 2011-12-08 15:26:18 PST
Comment on attachment 118478 [details] Adds support for visited link searching. View in context: https://bugs.webkit.org/attachment.cgi?id=118478&action=review > LayoutTests/platform/mac/accessibility/search-predicate.html:330 > + shouldBe("resultElement.role", "'AXRole: AXLink'"); Probably also want to verify that this link is actually visited. is that possible in DRT? also no need to define searchKey and isDirectionNext. I think you can put those directly in uiElementForSearchPredicate and save two more lines of code
Samuel White
Comment 3 2011-12-08 16:32:49 PST
Created attachment 118487 [details] Added link verification. Implemented suggested changes.
chris fleizach
Comment 4 2011-12-08 17:37:22 PST
Comment on attachment 118487 [details] Added link verification. thanks. r=me
WebKit Review Bot
Comment 5 2011-12-08 19:28:41 PST
Comment on attachment 118487 [details] Added link verification. Clearing flags on attachment: 118487 Committed r102421: <http://trac.webkit.org/changeset/102421>
WebKit Review Bot
Comment 6 2011-12-08 19:28:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.