Summary: | Accessibility object searching layout tests are incomplete. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Samuel White <samuel.white> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cfleizach, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Samuel White
2011-12-08 14:41:01 PST
Created attachment 118478 [details]
Adds support for visited link searching.
Also, removed unimplemented frames searching as it covered by tests in platform/mac/accessibility/search-with-frames.html.
Comment on attachment 118478 [details] Adds support for visited link searching. View in context: https://bugs.webkit.org/attachment.cgi?id=118478&action=review > LayoutTests/platform/mac/accessibility/search-predicate.html:330 > + shouldBe("resultElement.role", "'AXRole: AXLink'"); Probably also want to verify that this link is actually visited. is that possible in DRT? also no need to define searchKey and isDirectionNext. I think you can put those directly in uiElementForSearchPredicate and save two more lines of code Created attachment 118487 [details]
Added link verification.
Implemented suggested changes.
Comment on attachment 118487 [details]
Added link verification.
thanks. r=me
Comment on attachment 118487 [details] Added link verification. Clearing flags on attachment: 118487 Committed r102421: <http://trac.webkit.org/changeset/102421> All reviewed patches have been landed. Closing bug. |