Bug 74116

Summary:

Convert some fast/regions pixel tests to reftests

Product:

WebKit

Reporter:

Jacob Goldstein <jacobg>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jacobg, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.6

Attachments:

Description	Flags
Patch	none

Jacob Goldstein

Reported 2011-12-08 12:02:12 PST

Convert some fast/regions pixel tests to reftests

Attachments
Patch (86.12 KB, patch) 2011-12-08 14:26 PST, Jacob Goldstein	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jacob Goldstein

Comment 1 2011-12-08 14:26:05 PST

Created attachment 118470 [details] Patch

Darin Adler

Comment 2 2011-12-08 14:38:46 PST

Comment on attachment 118470 [details] Patch In the future, when changing tests to be reference tests, I would like to add explanatory text at the top of the test. Tests that have only the test content with no explanation are unnecessarily mysterious. With render tree results there is an excuse to not want extraneous content cluttering up the expected result, but with ref tests we can just repeat the explanation in both the test and the expected results.

WebKit Review Bot

Comment 3 2011-12-08 17:13:45 PST

Comment on attachment 118470 [details] Patch Clearing flags on attachment: 118470 Committed r102402: <http://trac.webkit.org/changeset/102402>

WebKit Review Bot

Comment 4 2011-12-08 17:13:49 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.