Bug 74116

Summary: Convert some fast/regions pixel tests to reftests
Product: WebKit Reporter: Jacob Goldstein <jacobg>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jacobg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
Attachments:
Description Flags
Patch none

Description Jacob Goldstein 2011-12-08 12:02:12 PST
Convert some fast/regions pixel tests to reftests
Comment 1 Jacob Goldstein 2011-12-08 14:26:05 PST
Created attachment 118470 [details]
Patch
Comment 2 Darin Adler 2011-12-08 14:38:46 PST
Comment on attachment 118470 [details]
Patch

In the future, when changing tests to be reference tests, I would like to add explanatory text at the top of the test. Tests that have only the test content with no explanation are unnecessarily mysterious. With render tree results there is an excuse to not want extraneous content cluttering up the expected result, but with ref tests we can just repeat the explanation in both the test and the expected results.
Comment 3 WebKit Review Bot 2011-12-08 17:13:45 PST
Comment on attachment 118470 [details]
Patch

Clearing flags on attachment: 118470

Committed r102402: <http://trac.webkit.org/changeset/102402>
Comment 4 WebKit Review Bot 2011-12-08 17:13:49 PST
All reviewed patches have been landed.  Closing bug.