Bug 74104

Summary:

Web Inspector: return node counts on the document / detached root basis

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, gustavo.noronha, gustavo, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed patch.	yurys: review+, gyuyoung.kim: commit-queue-
[PATCH] For ews.	webkit-ews: commit-queue-
[PATCH] For ews.	webkit-ews: commit-queue-
[PATCH] For ews. sorry for spam.	webkit-ews: commit-queue-

Pavel Feldman

Reported 2011-12-08 10:43:50 PST

Patch to follow.

Attachments
[PATCH] Proposed patch. (10.12 KB, patch) 2011-12-08 10:45 PST, Pavel Feldman	yurys: review+ gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
[PATCH] For ews. (10.32 KB, patch) 2011-12-08 11:12 PST, Pavel Feldman	webkit-ews: commit-queue-	Details Formatted Diff Diff
[PATCH] For ews. (10.31 KB, patch) 2011-12-08 11:47 PST, Pavel Feldman	webkit-ews: commit-queue-	Details Formatted Diff Diff
[PATCH] For ews. sorry for spam. (12.05 KB, patch) 2011-12-08 11:57 PST, Pavel Feldman	webkit-ews: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-12-08 10:45:18 PST

Created attachment 118419 [details] [PATCH] Proposed patch.

WebKit Review Bot

Comment 2 2011-12-08 10:50:35 PST

Attachment 118419 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorMemoryAgent.cpp:50: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:60: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:65: The parameter name "domAgent" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gyuyoung Kim

Comment 3 2011-12-08 10:50:49 PST

Comment on attachment 118419 [details] [PATCH] Proposed patch. Attachment 118419 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10809308

Early Warning System Bot

Comment 4 2011-12-08 10:51:27 PST

Comment on attachment 118419 [details] [PATCH] Proposed patch. Attachment 118419 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10797302

Collabora GTK+ EWS bot

Comment 5 2011-12-08 10:59:53 PST

Comment on attachment 118419 [details] [PATCH] Proposed patch. Attachment 118419 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10780309

Yury Semikhatsky

Comment 6 2011-12-08 11:00:21 PST

Comment on attachment 118419 [details] [PATCH] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=118419&action=review This changed should be accompanied with a test. > Source/WebCore/bindings/v8/ScriptProfiler.cpp:220 > + CounterVisitor counterVisitor(domAgent, result.get()); This visitor will traverse all nodes no matter which page they belong too. We should collect only nodes relevant to a particular page which user is inspecting. You can filter them by node->document()->frame()->page() for attached documents and report all nodes from alive detached documents.

Pavel Feldman

Comment 7 2011-12-08 11:12:09 PST

Created attachment 118428 [details] [PATCH] For ews.

WebKit Review Bot

Comment 8 2011-12-08 11:15:20 PST

Attachment 118428 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorMemoryAgent.cpp:50: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:60: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:65: The parameter name "domAgent" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 9 2011-12-08 11:40:43 PST

Comment on attachment 118428 [details] [PATCH] For ews. Attachment 118428 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10797319

Pavel Feldman

Comment 10 2011-12-08 11:47:08 PST

Created attachment 118435 [details] [PATCH] For ews.

WebKit Review Bot

Comment 11 2011-12-08 11:49:43 PST

Attachment 118435 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorMemoryAgent.cpp:50: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:60: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:65: The parameter name "domAgent" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 12 2011-12-08 11:52:16 PST

Comment on attachment 118435 [details] [PATCH] For ews. Attachment 118435 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10809334

Pavel Feldman

Comment 13 2011-12-08 11:57:49 PST

Created attachment 118438 [details] [PATCH] For ews. sorry for spam.

WebKit Review Bot

Comment 14 2011-12-08 12:00:48 PST

Attachment 118438 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorMemoryAgent.cpp:50: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:60: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorMemoryAgent.h:65: The parameter name "domAgent" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 15 2011-12-08 12:02:43 PST

Comment on attachment 118438 [details] [PATCH] For ews. sorry for spam. Attachment 118438 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10790342

Pavel Feldman

Comment 16 2011-12-08 12:51:52 PST

Landed as http://trac.webkit.org/changeset/102366.

Note You need to log in before you can comment on or make changes to this bug.