Bug 74101

Summary: [Qt] Update WebGraphicLayer's child content scale in all child binding method.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch noam: review+

Jocelyn Turcotte
Reported 2011-12-08 09:52:21 PST
[Qt] Update WebGraphicLayer's child content scale in all child binding method.
Attachments
Patch (3.94 KB, patch)
2011-12-08 09:55 PST, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (3.39 KB, patch)
2011-12-08 10:05 PST, Jocelyn Turcotte 		noam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-12-08 09:55:30 PST
Created attachment 118409 [details] Patch
Noam Rosenthal
Comment 2 2011-12-08 09:58:06 PST
Comment on attachment 118409 [details] Patch not sure this is needed, since e.g. GraphicsLayer::addChildBelow endds up calling setChildren
Jocelyn Turcotte
Comment 3 2011-12-08 09:59:05 PST
Comment on attachment 118409 [details] Patch Got to remove the modification to addChildren. If the content scale is the same this would cause notifyChange not to be called to send the parent layer update.
Jocelyn Turcotte
Comment 4 2011-12-08 10:05:00 PST
Created attachment 118413 [details] Patch
Jocelyn Turcotte
Comment 5 2011-12-08 10:06:30 PST
(In reply to comment #2) > (From update of attachment 118409 [details]) > not sure this is needed, since e.g. GraphicsLayer::addChildBelow endds up calling setChildren m_children is modified, but I don't see it calling setChildren, is it straight in GraphicsLayer::addChildBelow?
Jocelyn Turcotte
Comment 6 2011-12-09 09:41:20 PST
Committed r102457: <http://trac.webkit.org/changeset/102457>
Note You need to log in before you can comment on or make changes to this bug.