Bug 74096

Summary: Remove EventListenerMap destructor.
Product: WebKit Reporter: Andreas Kling <kling>
Component: UI EventsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Andreas Kling
Reported 2011-12-08 08:40:52 PST
Now that the internal HashMap stores OwnPtrs it will clean up itself, so we can let the compiler generate ~EventListenerMap().
Attachments
Patch (1.66 KB, patch)
2011-12-08 09:18 PST, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-12-08 09:18:28 PST
Created attachment 118404 [details] Patch
Darin Adler
Comment 2 2011-12-08 10:06:22 PST
Comment on attachment 118404 [details] Patch I think the no iterator assert is pretty superfluous anyway. The hash map iterators already do assertions like that and our iterator is built on hash map iterators. We might want to double check that the hash map iterator checks are thorough enough and remove this extra code for EventListenerIterator.
Andreas Kling
Comment 3 2011-12-08 10:50:52 PST
Committed r102349: <http://trac.webkit.org/changeset/102349>
Note You need to log in before you can comment on or make changes to this bug.