Bug 74085

Summary: Inspector: Don't translate the context when rendering the highlights on a tiled layer.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, joepeck, kenneth, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kenneth: review+
Manual test none

Jocelyn Turcotte
Reported 2011-12-08 06:27:25 PST
Inspector: Don't translate the context when rendering the highlights on a tiled layer.
Attachments
Patch (6.16 KB, patch)
2011-12-08 07:12 PST, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
Manual test (1.30 KB, text/html)
2011-12-12 08:54 PST, Jocelyn Turcotte 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-12-08 07:12:55 PST
Created attachment 118386 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-12-09 01:50:15 PST
Comment on attachment 118386 [details] Patch r=me
Jocelyn Turcotte
Comment 3 2011-12-09 09:38:43 PST
Committed r102456: <http://trac.webkit.org/changeset/102456>
Pavel Feldman
Comment 4 2011-12-09 10:12:12 PST
Alexander, Joe, are you cool with these changes? I know there has been a number of incremental improvements to this code related to scrollers and iframes that you worked on.
Pavel Feldman
Comment 5 2011-12-09 10:12:46 PST
(Btw, please use webkit.org/new-inspector-bug for the inspector bug template)
Joseph Pecoraro
Comment 6 2011-12-09 12:06:17 PST
(In reply to comment #4) > Alexander, Joe, are you cool with these changes? I know there has been a > number of incremental improvements to this code related to scrollers and > iframes that you worked on. Looks good to me, Qt guys would need to know best here since "delegatesScrolling" appears to only be used by them! That function name is not a very useful name in this context but the comment helps clarify that. It would also be good to attach a simple .html test case to this bugzilla bug so that a test of this since there was no manual test or LayoutTest included in the patch. This might fix Qt but other ports might be broken for such a case.
Kenneth Rohde Christiansen
Comment 7 2011-12-10 07:39:26 PST
delegatesScrolling basically means that webcore doesnt handle scrolling but the ui does (ie tiled backing store). If you have a better name that would be great. I guess you need something similar for iOS
Jocelyn Turcotte
Comment 8 2011-12-12 08:54:39 PST
Created attachment 118801 [details] Manual test Here's a manual test file, tell me if you would prefer me to push it too or if it needs adjustments. Thanks for looking at the patch.
Note You need to log in before you can comment on or make changes to this bug.