Summary: | [Qt] [WK2] Directly composited images don't render | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Viatcheslav Ostapenko <ostap73> | ||||
Component: | Images | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | hausmann, noam, webkit.review.bot | ||||
Priority: | P3 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Viatcheslav Ostapenko
2011-12-07 23:11:06 PST
Images do not attach to WebGraphicsLayer because graphics layer not yet attached to parent and layerTreeTileClient is 0. Created attachment 118337 [details]
Patch
Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid putting the extra logic into syncCompositingStateForThisLayerOnly? (In reply to comment #3) > Looks good to me, but I'll let Noam do the review. Perhaps there's a way to avoid putting the extra logic into syncCompositingStateForThisLayerOnly? syncCompositingStateForThisLayerOnly is where the per-layer synchronization should occur; I'm good with adding that logic there. Comment on attachment 118337 [details] Patch Clearing flags on attachment: 118337 Committed r102342: <http://trac.webkit.org/changeset/102342> All reviewed patches have been landed. Closing bug. |