Bug 74031

Summary: fix build-webkit --chromium after breakage in r102201
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Dirk Pranke 2011-12-07 15:59:34 PST
fix build-webkit --chromium after breakage in r102201
Comment 1 Dirk Pranke 2011-12-07 16:01:55 PST
Created attachment 118285 [details]
Patch
Comment 2 Tony Chang 2011-12-07 16:02:49 PST
Comment on attachment 118285 [details]
Patch

It would be nice to add a reason for the breakage here and what the fix is.
Comment 3 Dirk Pranke 2011-12-07 16:04:50 PST
done.
Comment 4 Dirk Pranke 2011-12-07 16:12:57 PST
Committed r102280: <http://trac.webkit.org/changeset/102280>
Comment 5 Kentaro Hara 2011-12-08 05:05:12 PST
Reverted r102280 for reason:

Chromium/Windows build is broken

Committed r102332: <http://trac.webkit.org/changeset/102332>
Comment 6 Kentaro Hara 2011-12-08 05:40:34 PST
(In reply to comment #5)
> Reverted r102280 for reason:
> 
> Chromium/Windows build is broken
> 
> Committed r102332: <http://trac.webkit.org/changeset/102332>

I am sorry. I first thought that this patch caused Chromium/Windows build failure, but actually it was innocent. I cq+ed again.
Comment 7 WebKit Review Bot 2011-12-08 06:51:11 PST
Comment on attachment 118285 [details]
Patch

Clearing flags on attachment: 118285

Committed r102335: <http://trac.webkit.org/changeset/102335>
Comment 8 WebKit Review Bot 2011-12-08 06:51:16 PST
All reviewed patches have been landed.  Closing bug.