Bug 74005

Summary:

[SH4] Unaligned data access in YARR_JIT

Product:

WebKit

Reporter:

thouraya <thouraya.andolsi>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
patch to fix the issue	none
patch to fix the issue	barraclough: review-
fix issue	none

thouraya

Reported 2011-12-07 09:32:06 PST

Hi, In the function generatePatternCharacterOnce, there is a case when a word is loaded from the input string, but this data access is not aligned. Regards, Thouraya.

Attachments
patch to fix the issue (8.69 KB, patch) 2011-12-07 09:37 PST, thouraya	no flags	Details Formatted Diff Diff
patch to fix the issue (11.31 KB, patch) 2011-12-07 09:59 PST, thouraya	barraclough: review-	Details Formatted Diff Diff
fix issue (11.17 KB, patch) 2011-12-08 00:18 PST, thouraya	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

thouraya

Comment 1 2011-12-07 09:37:27 PST

Created attachment 118219 [details] patch to fix the issue

WebKit Review Bot

Comment 2 2011-12-07 09:39:11 PST

Attachment 118219 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:174: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

thouraya

Comment 3 2011-12-07 09:59:01 PST

Created attachment 118224 [details] patch to fix the issue

Gavin Barraclough

Comment 4 2011-12-07 22:01:40 PST

Comment on attachment 118224 [details] patch to fix the issue 'WithUnalignedHalfBytes' doesn't really make a lot of sense - it's not misaligned to half a byte! Since there is only one misalignment of a 16 bit access, I think we should name this method load16Unaligned.

thouraya

Comment 5 2011-12-08 00:18:40 PST

Created attachment 118343 [details] fix issue

WebKit Review Bot

Comment 6 2011-12-08 15:17:10 PST

Comment on attachment 118343 [details] fix issue Clearing flags on attachment: 118343 Committed r102389: <http://trac.webkit.org/changeset/102389>

WebKit Review Bot

Comment 7 2011-12-08 15:17:14 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.