[SH4] Unaligned data access in YARR_JIT

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[thouraya]

Hi,

In the function generatePatternCharacterOnce, there is a case when a word is loaded from the input string, but this data access is not aligned.

Regards,
Thouraya.

[thouraya]

Created attachment 118219 [details]
patch to fix the issue

[WebKit Review Bot]

Attachment 118219 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:174:  Missing space before ( in if(  [whitespace/parens] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[thouraya]

Created attachment 118224 [details]
patch to fix the issue

[Gavin Barraclough]

Comment on attachment 118224 [details]
patch to fix the issue

'WithUnalignedHalfBytes' doesn't really make a lot of sense - it's not misaligned to half a byte!
Since there is only one misalignment of a 16 bit access, I think we should name this method load16Unaligned.

[thouraya]

Created attachment 118343 [details]
fix issue

[WebKit Review Bot]

Comment on attachment 118343 [details]
fix issue

Clearing flags on attachment: 118343

Committed r102389: <http://trac.webkit.org/changeset/102389>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.