Bug 73958

Summary: [chromium] Clearing root surface should happen after damage tracking
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, cc-bugs, enne, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2011-12-06 15:52:47 PST
There was a minor bug in the scissoring optimization that the root surface clear was happening before the scissor was actually computed. I went ahead cleaned up that code at the same time. No obvious regressions on layout tests on OSX, works fine with manual testing. Jonathan, can you please verify that this patch fixes the partial swap problem on your side before we flag it for official review? (Don't forget to manually remove the usingPartialSwap=false, otherwise it will seem to work without actually doing partial swap) Thanks in advance!
Attachments
Patch (5.04 KB, patch)
2011-12-06 15:57 PST, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2011-12-06 15:57:50 PST
Created attachment 118128 [details] Patch
Jonathan Backer
Comment 2 2011-12-07 07:37:54 PST
Fixes the problems that I was having with OSX 10.6
James Robinson
Comment 3 2011-12-07 17:43:52 PST
Comment on attachment 118128 [details] Patch OK
WebKit Review Bot
Comment 4 2011-12-07 18:02:31 PST
Comment on attachment 118128 [details] Patch Clearing flags on attachment: 118128 Committed r102294: <http://trac.webkit.org/changeset/102294>
WebKit Review Bot
Comment 5 2011-12-07 18:02:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.