Bug 73942 – webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find

[Adam Roben (:aroben)]

Created attachment 118086 [details]
Patch

[Adam Roben (:aroben)]

Committed r102163: <http://trac.webkit.org/changeset/102163>

[Eric Seidel (no email)]

Comment on attachment 118086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=118086&action=review

> Tools/ChangeLog:17
> +        (CrashLogs.find_newest_log): Added an optional pid parameter.
> +        (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
> +        candidate log's app_description extended attribute to see if that log corresponds to a
> +        crashed process with the specified PID.

I'm surprised you do this via xattr instead of just parsing the text files.

[Eric Seidel (no email)]

Does this work on SL as well as Lion?

[Adam Roben (:aroben)]

(In reply to comment #3)
> I'm surprised you do this via xattr instead of just parsing the text files.

I figured xattr would be faster.

(In reply to comment #4)
> Does this work on SL as well as Lion?

Looks like Snow Leopard doesn't set any attributes that contain the PID. :-(

[Adam Roben (:aroben)]

Thanks for pointing that out, Eric. Bug 74094 contains a fix.