Bug 73930

Summary: Web Inspector: introduce a memory agent stub.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, dglazkov, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
[Patch] with renamed method and a JSC bug reference. timothy: review+, webkit.review.bot: commit-queue-

Pavel Feldman
Reported 2011-12-06 10:05:39 PST
We'd like to experiment with the memory stats and hence need a nice home for that. Adding this undocumented agent / domain for now.
Attachments
Patch (19.67 KB, patch)
2011-12-06 10:35 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (19.67 KB, patch)
2011-12-06 10:41 PST, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] with renamed method and a JSC bug reference. (19.76 KB, patch)
2011-12-06 11:06 PST, Pavel Feldman 		timothy: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-12-06 10:35:04 PST
Created attachment 118068 [details] Patch
Pavel Feldman
Comment 2 2011-12-06 10:41:17 PST
Created attachment 118069 [details] Patch
Timothy Hatcher
Comment 3 2011-12-06 10:42:40 PST
Comment on attachment 118069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118069&action=review > Source/WebCore/bindings/js/ScriptProfiler.h:61 > + static unsigned nodeCount() { return 0; } Where is the JSC implementation or the bug? Please add a FIXME to the code where JSC just returns 0.
Timothy Hatcher
Comment 4 2011-12-06 10:44:11 PST
Also, what does "node" mean in this? DOM node or some JS memory node/cell?
Pavel Feldman
Comment 5 2011-12-06 11:06:08 PST
Created attachment 118073 [details] [Patch] with renamed method and a JSC bug reference.
Timothy Hatcher
Comment 6 2011-12-06 11:10:13 PST
Comment on attachment 118073 [details] [Patch] with renamed method and a JSC bug reference. View in context: https://bugs.webkit.org/attachment.cgi?id=118073&action=review > Source/WebCore/bindings/js/ScriptProfiler.h:61 > + // FIXME: Implement this counter for JSC. See BUG73936 for more details. "bug 73936" instead of "BUG73936" unless this is standard form in WebKit now.
WebKit Review Bot
Comment 7 2011-12-06 14:44:43 PST
Comment on attachment 118073 [details] [Patch] with renamed method and a JSC bug reference. Attachment 118073 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10742107
Pavel Feldman
Comment 8 2011-12-06 15:49:37 PST
Committed r102187: <http://trac.webkit.org/changeset/102187>
Note You need to log in before you can comment on or make changes to this bug.