Bug 73928

Summary:

Put length in its own variable in KURL copyASCII

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit Misc.

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

Attachments:

Description	Flags
Patch	darin: review+

Benjamin Poulain

Reported 2011-12-06 09:51:37 PST

Darin is concerned for (size_t i = 0; i < string.length(); i++) my cause performance problem due to string.length().

Attachments
Patch (1.28 KB, patch) 2011-12-06 09:57 PST, Benjamin Poulain	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2011-12-06 09:57:12 PST

Darin Adler

Comment 2 2011-12-06 10:13:55 PST

Comment on attachment 118063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118063&action=review > Source/WebCore/platform/KURL.cpp:267 > + const size_t length = string.length(); Please remove the const (or you could make src also const and build a bicycle shed).

Benjamin Poulain

Comment 3 2011-12-06 14:05:11 PST

Note You need to log in before you can comment on or make changes to this bug.