Bug 73923

Summary:

[Qt] QQuickWebView missing titleChanged signal tests

Product:

WebKit

Reporter:

Gopal Raghavan <gopal.1.raghavan>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot, zoltan

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
verify titleChanged signal	none

Gopal Raghavan

Reported 2011-12-06 08:13:28 PST

Signal tests are missing for titleChanged

Attachments
verify titleChanged signal (3.06 KB, patch) 2011-12-06 08:18 PST, Gopal Raghavan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gopal Raghavan

Comment 1 2011-12-06 08:18:25 PST

Created attachment 118054 [details] verify titleChanged signal added qml tests to veriy titleChanged signal

Simon Hausmann

Comment 2 2011-12-07 00:22:17 PST

Comment on attachment 118054 [details] verify titleChanged signal View in context: https://bugs.webkit.org/attachment.cgi?id=118054&action=review > Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/test3.html:8 > + var t = setTimeout("changeTitle('New Title')",3000); If you want you can write this without an extra function I think, just setTimeout("document.title = 'New Title', 3000)

WebKit Review Bot

Comment 3 2011-12-11 19:25:37 PST

Comment on attachment 118054 [details] verify titleChanged signal Clearing flags on attachment: 118054 Committed r102554: <http://trac.webkit.org/changeset/102554>

WebKit Review Bot

Comment 4 2011-12-11 19:25:41 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.