Summary: | [qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Brüning <michael.bruning> | ||||||||
Component: | WebKit2 | Assignee: | Michael Brüning <michael.bruning> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | kenneth, webkit.review.bot, zoltan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Michael Brüning
2011-12-06 04:28:53 PST
Created attachment 118028 [details]
Patch to fix assertion.
Comment on attachment 118028 [details] Patch to fix assertion. View in context: https://bugs.webkit.org/attachment.cgi?id=118028&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:79 > +{ > + if (interactionEngine) > + interactionEngine->blockSignals(true); > +} why not disconnect all signals? Created attachment 118035 [details]
Updated patch using disconnect instead of blockSignals
Update according to Kenneth's comment.
Comment on attachment 118035 [details]
Updated patch using disconnect instead of blockSignals
Updating flags
Comment on attachment 118035 [details] Updated patch using disconnect instead of blockSignals View in context: https://bugs.webkit.org/attachment.cgi?id=118035&action=review > Source/WebKit2/ChangeLog:8 > + * UIProcess/API/qt/qquickwebview.cpp: Block signals from QtViewportInteractionEngine in diconnect Created attachment 118041 [details]
Patch with fixed ChangeLog and commit message.
Fixed the ChangeLog and commit message.
Comment on attachment 118041 [details] Patch with fixed ChangeLog and commit message. Clearing flags on attachment: 118041 Committed r102142: <http://trac.webkit.org/changeset/102142> All reviewed patches have been landed. Closing bug. |