Bug 73878 – webkit.py: Really fix the printing of StringImpl now that 8 bit strings are present

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}. r98785 made webkit.py always use m_data16, which does not work when the string is an 8-bit string (such as KURL::string()).

I was not able to directly call StringImpl::is8Bit() in the Python code, so I just reproduced the implementation there.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 117956 [details]
Patch

[Tony Chang]

Comment on attachment 117956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117956&action=review

> Tools/gdb/webkit.py:112
> +        return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \
> +               self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']

The line wrapping is wrong (incorrect indention), but I would either just make this a single line.

> Tools/gdb/webkit.py:136
> +        return self.val['m_impl']['m_ptr']['m_hashAndFlags'] & \
> +               self.val['m_impl']['m_ptr']['s_hashFlag8BitBuffer']

Ditto.

[Raphael Kubo da Costa (:rakuco)]

Committed r102083: <http://trac.webkit.org/changeset/102083>