Bug 73871

Summary: Create StringImpl::empty() as an 8 bit string
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 73236    
Attachments:
Description Flags
Patch oliver: review+

Michael Saboff
Reported 2011-12-05 15:38:06 PST
The zero length empty string returned by the static method StringImpl ::empty() should be created as an 8 bit string. This will help performance when concatenated with other strings.
Attachments
Patch (1.45 KB, patch)
2011-12-05 17:50 PST, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-12-05 17:50:30 PST
Created attachment 117968 [details] Patch This patch provides no performance benefit by itself, but allows for future changes that concat null strings to use an 8 bit path.
Michael Saboff
Comment 2 2011-12-05 18:07:02 PST
Committed r102082: <http://trac.webkit.org/changeset/102082>
Darin Adler
Comment 3 2011-12-06 09:21:01 PST
Comment on attachment 117968 [details] Patch Why?
Darin Adler
Comment 4 2011-12-06 09:21:32 PST
(In reply to comment #3) > Why? Oh, I see now. The rationale is in the bug, but not the patch. Next time please put it in the patch.
Note You need to log in before you can comment on or make changes to this bug.