Summary: | REGRESSION (r95249): Right side is truncated when printing | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | Printing | Assignee: | Kentaro Hara <haraken> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Critical | CC: | ap, hyatt, mitz, webkit.review.bot | ||||||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2011-12-05 14:50:36 PST
I'll take a look at it. Created attachment 118027 [details]
A simplified test case
When the attached html is printed, its right side is truncated.
Created attachment 118029 [details]
WIP patch
ap, hyatt: I uploaded a patch but I am not sure how I can write a test for the patch. We need to test if the right sides of all lines in width-overflow.html are printed without being truncated, but how can we know if the right side is truncated or not? While layoutTestController.setPrinting() tells us the position of a bottom border of a page, it does not tell us the position of a right border (as you can see in width-overflow-expected.png). Any idea? (In reply to comment #4) > ap, hyatt: I uploaded a patch but I am not sure how I can write a test for the patch. > > We need to test if the right sides of all lines in width-overflow.html are printed without being truncated, but how can we know if the right side is truncated or not? While layoutTestController.setPrinting() tells us the position of a bottom border of a page, it does not tell us the position of a right border (as you can see in width-overflow-expected.png). Any idea? Solved. I found that the right edge of the result of setPrinting() is the right border of the page:-) Created attachment 118178 [details]
patch for review
ap, hyatt: Here are the setPrinting() results with/without my patch. Without my patch: http://haraken.info/a/width-overflow-expected-before.png With my patch: http://haraken.info/a/width-overflow-expected-after.png Comment on attachment 118178 [details] patch for review Clearing flags on attachment: 118178 Committed r102281: <http://trac.webkit.org/changeset/102281> All reviewed patches have been landed. Closing bug. |