Bug 73867

Summary: V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antonm, japhet, rafaelw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73492    
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Klein
Reported 2011-12-05 14:32:38 PST
V8RecursionScope should call didLeaveScriptContext when recursionLevel reaches zero
Attachments
Patch (14.15 KB, patch)
2011-12-05 14:37 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.00 KB, patch)
2011-12-05 14:55 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-12-05 14:37:02 PST
Created attachment 117939 [details] Patch
Adam Barth
Comment 2 2011-12-05 14:40:06 PST
Comment on attachment 117939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117939&action=review > Source/WebCore/bindings/v8/V8RecursionScope.h:34 > +#if ENABLE(MUTATION_OBSERVERS) Presumably this shouldn't be conditional on MUTATION_OBSERVERS, right?
Adam Klein
Comment 3 2011-12-05 14:54:47 PST
Comment on attachment 117939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117939&action=review >> Source/WebCore/bindings/v8/V8RecursionScope.h:34 >> +#if ENABLE(MUTATION_OBSERVERS) > > Presumably this shouldn't be conditional on MUTATION_OBSERVERS, right? Heh, good catch, I picked a bad file to use as a template...Removed.
Adam Klein
Comment 4 2011-12-05 14:55:19 PST
Created attachment 117943 [details] Patch for landing
Adam Klein
Comment 5 2011-12-05 16:33:36 PST
Committed r102067: <http://trac.webkit.org/changeset/102067>
Note You need to log in before you can comment on or make changes to this bug.