Bug 73854

Summary:

small refactor of RenderFlexibleBox

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Tony Chang 2011-12-05 12:32:25 PST

small refactor of RenderFlexibleBox

Comment 1 Tony Chang 2011-12-05 12:34:25 PST

Created attachment 117918 [details]
Patch

Comment 2 Tony Chang 2011-12-05 12:35:07 PST

Easy review.  Makes the variable names more like the names in RenderFlexibleBox::layoutColumnReverse.

Comment 3 Darin Adler 2011-12-05 12:36:14 PST

Comment on attachment 117918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117918&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:627
> +        IntPoint childLocation(shouldFlipMainAxis ? totalMainExtent - mainAxisOffset - childMainExtent : mainAxisOffset,
> +                               crossAxisOffset + flowAwareMarginBeforeForChild(child));

WebKit formatting rules forbid this kind of lining up since it’s not renaming-infriendly.

Comment 4 Tony Chang 2011-12-05 13:08:29 PST

Created attachment 117928 [details]
Patch for landing

Comment 5 WebKit Review Bot 2011-12-05 20:59:27 PST

Comment on attachment 117928 [details]
Patch for landing

Clearing flags on attachment: 117928

Committed r102090: <http://trac.webkit.org/changeset/102090>

Comment 6 WebKit Review Bot 2011-12-05 20:59:31 PST

All reviewed patches have been landed.  Closing bug.