Bug 73845

Summary:

[Chromium] Remove no-longer-used forwarding headers in the WebKit API

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd, jamesr, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	fishd: review+

Description Adam Barth 2011-12-05 11:00:08 PST

[Chromium] Remove no-longer-used forwarding headers in the WebKit API

Comment 1 Adam Barth 2011-12-05 11:01:45 PST

Created attachment 117901 [details]
Patch

Comment 2 Adam Barth 2011-12-05 11:02:09 PST

Comment on attachment 117901 [details]
Patch

Oops.  Actually that patch has one cheat still in it.

Comment 3 Adam Barth 2011-12-05 11:04:47 PST

Created attachment 117902 [details]
Patch

Comment 4 WebKit Review Bot 2011-12-05 11:05:02 PST

Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.

Comment 5 James Robinson 2011-12-05 11:09:16 PST

Comment on attachment 117902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117902&action=review

> Source/WebKit/chromium/WebKit.gyp:279
> +                'public/android/WebInputEventFactory.h',

it looks like this is re-sorted in a case-sensitive way. are we supposed to do sorts ignoring case?

> Source/WebKit/chromium/src/AssociatedURLLoader.cpp:48
>  #include "WebFrameImpl.h"
> -#include "WebHTTPHeaderVisitor.h"
> +#include "platform/WebHTTPHeaderVisitor.h"
>  #include "WebKit.h"
> -#include "WebKitPlatformSupport.h"
> -#include "WebURLError.h"
> -#include "WebURLLoaderClient.h"
> -#include "WebURLRequest.h"
> +#include "platform/WebKitPlatformSupport.h"
> +#include "platform/WebURLError.h"
> +#include "platform/WebURLLoaderClient.h"
> +#include "platform/WebURLRequest.h"
>  #include "WrappedResourceRequest.h"

i think you need to resort these headers or the style bot will yell at you, won't it?

Comment 6 Adam Barth 2011-12-05 11:10:53 PST

(In reply to comment #5)
> (From update of attachment 117902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117902&action=review
> 
> > Source/WebKit/chromium/WebKit.gyp:279
> > +                'public/android/WebInputEventFactory.h',
> 
> it looks like this is re-sorted in a case-sensitive way. are we supposed to do sorts ignoring case?

WebKit uses case-sensitive sorting.

> > Source/WebKit/chromium/src/AssociatedURLLoader.cpp:48
> >  #include "WebFrameImpl.h"
> > -#include "WebHTTPHeaderVisitor.h"
> > +#include "platform/WebHTTPHeaderVisitor.h"
> >  #include "WebKit.h"
> > -#include "WebKitPlatformSupport.h"
> > -#include "WebURLError.h"
> > -#include "WebURLLoaderClient.h"
> > -#include "WebURLRequest.h"
> > +#include "platform/WebKitPlatformSupport.h"
> > +#include "platform/WebURLError.h"
> > +#include "platform/WebURLLoaderClient.h"
> > +#include "platform/WebURLRequest.h"
> >  #include "WrappedResourceRequest.h"
> 
> i think you need to resort these headers or the style bot will yell at you, won't it?

Done.  I'm not sure why check-webkit-style didn't complain.

Comment 7 Adam Barth 2011-12-05 11:14:00 PST

I sorted a bunch of these includes, but ran out of steam somewhere around BlobRegistry.

Comment 8 Adam Barth 2011-12-05 11:14:34 PST

Created attachment 117905 [details]
Patch

Comment 9 Adam Barth 2011-12-05 14:07:47 PST

Committed r102044: <http://trac.webkit.org/changeset/102044>