Bug 73841

Summary: On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Steve Falkenburg <sfalken>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Steve Falkenburg
Reported 2011-12-05 10:32:01 PST
On Windows, filenames not properly preserved when copied into a file list exposed by Event.dataTransfer
Attachments
Patch (1.38 KB, patch)
2011-12-05 10:33 PST, Steve Falkenburg 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2011-12-05 10:33:03 PST
Created attachment 117896 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-12-05 10:39:53 PST
Comment on attachment 117896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117896&action=review > Source/WebCore/ChangeLog:9 > + No new tests. (OOPS!) You should mention why this is. > Source/WebCore/platform/win/ClipboardWin.cpp:575 > - files->append(File::create((*it).characters())); > + files->append(File::create(*it)); It would be nice to explain in your ChangeLog why this fixes things. It took me a while to realize the problem must have been due to characters() not being null-terminated.
Steve Falkenburg
Comment 3 2011-12-05 10:47:04 PST
Committed r102016: <http://trac.webkit.org/changeset/102016>
Note You need to log in before you can comment on or make changes to this bug.