Bug 73806

Summary: [Chromium] unknown characters symbol on \n in complex script text (RTL and LTR)
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, jamesr, jshin, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://crbug.com/105494
Bug Depends on: 73991    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Kenichi Ishibashi
Reported 2011-12-05 02:01:48 PST
See http://crbug.com/105494 for details. In UniscribeHelper::fillRuns(), successive SCRIPT_ITEMs that are tagged SCRIPT_TAG_UNKNOWN are merged to reduce script runs. However, it seems that we shouldn't merge SCRIPT_ITEMs when it contains non-printable characters.
Attachments
Patch (5.25 KB, patch)
2011-12-05 18:00 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.14 KB, patch)
2011-12-06 15:59 PST, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2011-12-05 18:00:18 PST
Created attachment 117970 [details] Patch
Tony Chang
Comment 2 2011-12-06 09:33:29 PST
Comment on attachment 117970 [details] Patch Seems fine to me. Jungshik, do you want to review the code also?
Jungshik Shin
Comment 3 2011-12-06 13:31:22 PST
LG except that I like to add a LTR complex script case to the test. One taken from Chrome bug: <p>.%0A&#x0915;</p>
Tony Chang
Comment 4 2011-12-06 13:57:39 PST
Also, we should just put the new test in LayoutTests/fast/text/international/ rather than making it Chromium specific.
Kenichi Ishibashi
Comment 5 2011-12-06 15:59:11 PST
Created attachment 118129 [details] Patch for landing
Kenichi Ishibashi
Comment 6 2011-12-06 15:59:55 PST
(In reply to comment #5) > Created an attachment (id=118129) [details] > Patch for landing Addressed comments. Thank you for review!
WebKit Review Bot
Comment 7 2011-12-06 16:38:51 PST
Comment on attachment 118129 [details] Patch for landing Clearing flags on attachment: 118129 Committed r102190: <http://trac.webkit.org/changeset/102190>
WebKit Review Bot
Comment 8 2011-12-06 16:38:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.