Bug 73795

Summary:

Remove methods declared but never implemented with GOOGLEURL

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	abarth: review+

Benjamin Poulain

Reported 2011-12-04 20:29:28 PST

Created attachment 117830 [details] Patch Reviewed by NOBODY (OOPS!). * platform/KURL.h: --- 2 files changed, 8 insertions(+), 3 deletions(-)

Attachments
Patch (1.34 KB, patch) 2011-12-04 20:29 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (1.40 KB, patch) 2011-12-04 20:31 PST, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (1.45 KB, patch) 2011-12-04 20:40 PST, Benjamin Poulain	abarth: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2011-12-04 20:31:48 PST

Created attachment 117831 [details] Patch

WebKit Review Bot

Comment 2 2011-12-04 20:33:49 PST

Attachment 117831 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Benjamin Poulain

Comment 3 2011-12-04 20:39:55 PST

Why didn't webkit patch send the right diff? :(

Benjamin Poulain

Comment 4 2011-12-04 20:40:19 PST

Created attachment 117833 [details] Patch

Benjamin Poulain

Comment 5 2011-12-05 17:10:41 PST

Committed r102073: <http://trac.webkit.org/changeset/102073>

Note You need to log in before you can comment on or make changes to this bug.