Bug 73792

Summary: Get rid of KURL::KURL(ParsedURLStringTag, const char*);
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dglazkov, japhet, kling, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2011-12-04 19:10:15 PST
KURL::parse() takes a char* instead of the CharBuffer because of KURL::KURL(ParsedURLStringTag, const char*); That constructor does not seem to be used by anything important. Let's remove it and see if the bots like that better.
Attachments
Patch (6.13 KB, patch)
2011-12-04 19:20 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (7.51 KB, patch)
2011-12-04 20:24 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-12-04 19:20:55 PST
Created attachment 117825 [details] Patch
WebKit Review Bot
Comment 2 2011-12-04 20:13:40 PST
Comment on attachment 117825 [details] Patch Attachment 117825 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10734545
Benjamin Poulain
Comment 3 2011-12-04 20:23:12 PST
Ooops, forgot the GoogleURL implementation, fixing that... :)
Benjamin Poulain
Comment 4 2011-12-04 20:24:16 PST
Created attachment 117829 [details] Patch
Andreas Kling
Comment 5 2011-12-04 21:10:25 PST
Comment on attachment 117829 [details] Patch Looks great!
Benjamin Poulain
Comment 6 2011-12-04 21:14:43 PST
Comment on attachment 117829 [details] Patch I'll land tomorrow so Darin and Adam also have a chance to look at the patch.
Adam Barth
Comment 7 2011-12-04 21:39:36 PST
Comment on attachment 117829 [details] Patch Nice.
WebKit Review Bot
Comment 8 2011-12-05 17:51:45 PST
Comment on attachment 117829 [details] Patch Clearing flags on attachment: 117829 Committed r102080: <http://trac.webkit.org/changeset/102080>
WebKit Review Bot
Comment 9 2011-12-05 17:51:50 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.