Bug 73780

Summary: Convert JSClassRef to use HashMap<OwnPtr>
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73757    
Attachments:
Description Flags
Patch none

Description Darin Adler 2011-12-04 14:26:29 PST
Convert JSClassRef to use HashMap<OwnPtr>
Comment 1 Darin Adler 2011-12-04 14:31:04 PST
Created attachment 117808 [details]
Patch
Comment 2 Andreas Kling 2011-12-04 18:49:08 PST
Comment on attachment 117808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117808&action=review

> Source/JavaScriptCore/API/JSClassRef.cpp:82
>                  // Use a local variable here to sidestep an RVCT compiler bug.

Side-stepping RVCT bugs is not an issue anymore AFAIK.
Support for Symbian has been removed from WebKit trunk, and I believe it was the only user of RVCT.
(This comment repeated for each occurrence of that workaround.)
Comment 3 WebKit Review Bot 2011-12-05 16:17:53 PST
Comment on attachment 117808 [details]
Patch

Clearing flags on attachment: 117808

Committed r102065: <http://trac.webkit.org/changeset/102065>
Comment 4 WebKit Review Bot 2011-12-05 16:17:57 PST
All reviewed patches have been landed.  Closing bug.