Bug 73774

Summary: [WK2][GTK] enable-fullscreen WebSettings
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gns, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
enable-fullscreen web-setting
none
enable-fullscreen web-setting mrobinson: review+

Description Philippe Normand 2011-12-04 10:03:22 PST
Patch incoming...
Comment 1 Philippe Normand 2011-12-04 10:04:32 PST
Created attachment 117795 [details]
enable-fullscreen web-setting
Comment 2 WebKit Review Bot 2011-12-04 10:05:47 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2011-12-04 10:18:44 PST
Comment on attachment 117795 [details]
enable-fullscreen web-setting

All of the recent additions to WebSettings have included a very simple update to the unit tests. Do you mind adding this?
Comment 4 Philippe Normand 2011-12-04 10:24:56 PST
Created attachment 117797 [details]
enable-fullscreen web-setting
Comment 5 Martin Robinson 2011-12-04 10:34:17 PST
Comment on attachment 117797 [details]
enable-fullscreen web-setting

View in context: https://bugs.webkit.org/attachment.cgi?id=117797&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:741
> +     * Whether to enable the Javascript Fullscreen API.

Do you mind writing a small blurb about what the fullscreen API is and then also linking to the spec?
Comment 6 Philippe Normand 2011-12-04 11:10:09 PST
Committed r101962: <http://trac.webkit.org/changeset/101962>
Comment 7 Philippe Normand 2011-12-04 11:11:40 PST
(In reply to comment #5)
> (From update of attachment 117797 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117797&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:741
> > +     * Whether to enable the Javascript Fullscreen API.
> 
> Do you mind writing a small blurb about what the fullscreen API is and then also linking to the spec?

I did so. Thanks for the review!