Bug 73730

Summary: <video> elements should disable the system and display sleep when playing on OS X.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, eric.carlson, jon, mrowe, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ap: review+

Description Jer Noble 2011-12-02 18:48:33 PST 
<video> elements should disable the system and display sleep when playing on OS X.
Comment 1 Jer Noble 2011-12-02 21:58:51 PST 
Created attachment 117740 [details]
Patch
Comment 2 Jer Noble 2011-12-02 22:24:21 PST 
Created attachment 117743 [details]
Patch
Comment 3 Jer Noble 2011-12-02 23:32:13 PST 
Created attachment 117746 [details]
Patch
Comment 4 Mark Rowe (bdash) 2011-12-02 23:39:42 PST 
Comment on attachment 117746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117746&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:2508
> +        m_sleepDisabler = DisplaySleepDisabler::create("WebCore::HTMLMediaElement playback");

The reason for the power assertion doesn’t match the format used elsewhere in WebKit. It would be good to be consistent.
Comment 5 Mark Rowe (bdash) 2011-12-02 23:46:22 PST 
Also, it would be great if you could mention the associated Radar number both in Bugzilla and the ChangeLog.
Comment 6 Jer Noble 2011-12-03 15:53:57 PST 
<rdar://problem/9502155>
Comment 7 Jer Noble 2011-12-03 15:56:45 PST 
Created attachment 117773 [details]
Patch

While Mark already r+'d the previous patch, I thought this new patch was worth obsoleting that one.  This new patch has changes to the WebKit2 sandbox profile, which allows DisplaySleepDisabler to work when running in the WebProcess.
Comment 8 Alexey Proskuryakov 2011-12-05 10:59:26 PST 
Comment on attachment 117773 [details]
Patch

r=me
Comment 9 Jer Noble 2011-12-05 11:47:29 PST 
Committed r102024: <http://trac.webkit.org/changeset/102024>
Comment 10 Jer Noble 2011-12-19 10:34:02 PST 
*** Bug 65061 has been marked as a duplicate of this bug. ***