Summary: | Upstream the Cursor implementation of iOS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ddkilzer, sam, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Attachment 117717 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 117717 [details]
Patch
r=me as long as you add the bug number to the ChangeLog.
May also be worth filing a bug about a shared NullCursor implementation since the WinCE port does something similar to this.
Committed r102097: <http://trac.webkit.org/changeset/102097> |
Created attachment 117717 [details] Patch Reviewed by NOBODY (OOPS!). iOS does not need to support the Cursor of WebKit. For compatibility, Cursor is implemented as an empty class on the platform. * Configurations/WebCore.xcconfig: * WebCore.xcodeproj/project.pbxproj: * platform/Cursor.h: (WebCore::Cursor::Cursor): * platform/ios/CursorIOS.cpp: Added. (WebCore::cursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::grabCursor): (WebCore::grabbingCursor): (WebCore::determineHotSpot): --- 5 files changed, 328 insertions(+), 3 deletions(-)