Summary: | [Chromium] Add Android keycodes and build Linux clipboard/filesystem files. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Peter Beverloo <peter> | ||||||
Component: | Platform | Assignee: | Peter Beverloo <peter> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, cc-bugs, jamesr, jrg, steveblock, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 73849 | ||||||||
Bug Blocks: | 66687 | ||||||||
Attachments: |
|
Description
Peter Beverloo
2011-12-02 10:10:56 PST
Created attachment 117647 [details] Patch Note for the reviewers: An alternative solution to adding a new IconChromiumAndroid.cpp file would be to #ifdef out the implementation in IconChromium.cpp, but overall I think this is cleaner. http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/platform/graphics/chromium/IconChromium.cpp&exact_package=chromium&q=IconChromium.cpp&type=cs&l=48 Thanks! Comment on attachment 117647 [details] Patch Rejecting attachment 117647 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 112463 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 112463. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10729173 Created attachment 117858 [details]
Patch for landing
I have no idea where the ChangeLog disappeared to, anyway, hereby the patch for landing.
Comment on attachment 117858 [details] Patch for landing Clearing flags on attachment: 117858 Committed r102018: <http://trac.webkit.org/changeset/102018> All reviewed patches have been landed. Closing bug. |