Bug 73640

Summary: REGRESSION(r101755): Layout Test fast/events/offsetX-offsetY.html is failing
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ap, dglazkov, hbono, mitz, rniwa, simon.fraser, tony, webkit.review.bot, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch v0
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03
Patch v1 (Removed a rebaselined result) none

Description Vsevolod Vlasov 2011-12-02 03:11:26 PST
The following layout test is failing on chromium-mac


Probable cause:


Updated test expectations: http://trac.webkit.org/changeset/101774
Comment 1 Vsevolod Vlasov 2011-12-02 07:29:50 PST
Moved test expectations to stop chromium-cg-mac failing.
Comment 2 Ryosuke Niwa 2012-04-26 22:59:00 PDT
*** Bug 73979 has been marked as a duplicate of this bug. ***
Comment 3 Hironori Bono 2012-06-27 23:55:09 PDT
Created attachment 149889 [details]
Patch v0

Greetings Simon,

I would like to change this test so it can calculate client positions from offset positions at run time to remove platform-dependent constants from this test, i.e. to make this test platform-independent. Even though I'm not sure about the context of this test, would it be possible to give me your comments?
Thank you for your help in advance.


Hironori Bono
Comment 4 Hironori Bono 2012-06-27 23:56:42 PDT

As far as I have tested by myself, this test succeeds on my Lion and Linux (Qt).


Hironori Bono
Comment 5 WebKit Review Bot 2012-06-28 03:59:15 PDT
Comment on attachment 149889 [details]
Patch v0

Attachment 149889 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13102976

New failing tests:
Comment 6 WebKit Review Bot 2012-06-28 03:59:20 PDT
Created attachment 149916 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 7 Hironori Bono 2012-06-28 04:10:01 PDT

Oops, I forgot deleting the existing (and badly) rebaselined results. I will upload another change that deletes them.


Hironori Bono
Comment 8 Tony Chang 2012-06-28 11:18:40 PDT
Comment on attachment 149889 [details]
Patch v0

Removing from the review queue since Hironori said he's going to upload a new patch.
Comment 9 Hironori Bono 2012-06-28 23:49:59 PDT
Created attachment 150093 [details]
Patch v1 (Removed a rebaselined result)


I have updated this change to remove the rebaselined result used by Chromium. (Except removing a rebaselined result, this change is the same one as the previous one.) I have verified this change succeeds on Chromium (Linux, Mac, Win7), Mac (Lion), and Qt (Linux). (Unfortunately, I cannot build GTK WebKit on my Ubuntu (12.4) PC and cannot test it with GTK WebKit.)


Hironori Bono
Comment 10 WebKit Review Bot 2012-07-03 00:06:25 PDT
Comment on attachment 150093 [details]
Patch v1 (Removed a rebaselined result)

Clearing flags on attachment: 150093

Committed r121735: <http://trac.webkit.org/changeset/121735>
Comment 11 WebKit Review Bot 2012-07-03 00:06:31 PDT
All reviewed patches have been landed.  Closing bug.