Bug 73630 – [Qt] Change default WebSocket protocol to the latest one

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Yuta Kitamura]

Currently, WebKitQt only supports the old WebSocket protocol (hixie-76). The old protocol is known to have a security defect, and should be phased out into the new protocol.

The new protocol (hybi-17, which is going to be published as RFC6455 soon) is already implemented in WebCore and we can switch to the new protocol using WebCore::Settings.

LayoutTests for hybi-17 are running fine on Qt bots, hence we essentially just need to switch the default value of a Settings flag.

Qt folks, are you happy with this change? Maybe I should bring up this topic on webkit-qt list?

(Note: the old protocol and the new one are incompatible; if there's any existing service depending on the old protocol, it will break.)

[Alexander Færøy]

Sure, we would be happy with that change :)

[Simon Hausmann]

I'd say go for it. I'm not aware of anyone using the Qt port and relying on a particular web socket protocol version. I'm inclined to say that our interest is to follow the majority of the other ports in this regards and if there was a "project default" (that ports _may_ optionally deviate from), then I think we'd be in the group interested in following the default, at this point.

[Jocelyn Turcotte]

We never officially supported the InspectorServerQt in WebKit/qt but this will break the support for QtWebKit clients with it.

On the other hand I need this to be switched on to support the new remote inspector in WebKit2, so I'm looking forward to this :)

[Yuta Kitamura]

(In reply to comment #2)
> I'd say go for it. I'm not aware of anyone using the Qt port and relying on a particular web socket protocol version. I'm inclined to say that our interest is to follow the majority of the other ports in this regards and if there was a "project default" (that ports _may_ optionally deviate from), then I think we'd be in the group interested in following the default, at this point.

I'm fine with either following the project default or switching right now.

Before switching the project default, I'd like to confirm the hybi tests run fine on WebKit2 bots (and fix any issues if found). The tests aren't run at this moment as WebKitTestRunner lacks LayoutTestController.overridePreference() implementation.

[Jesus Sanchez-Palencia]

What is the status of this?

[Yuta Kitamura]

GTK already transitioned (bug 74064), Mac/Win/WK2 also transitioned (bug 78541). So I think, among the ports I'm aware of, Qt is the only one left on the old protocol.

Sounds like it's time to switch the flag for Qt, and also flip the WebCore-global default value.

I'd like to make the transition two-fold:
1) Complete the transition on Qt and make sure things are fine.
2) Flip the global default value and remove port-specific defaults.

Does this make sense? If so, I'm going to upload a patch that just changes Qt's default.

[Yuta Kitamura]

(In reply to comment #6)
> I'd like to make the transition two-fold:
> 1) Complete the transition on Qt and make sure things are fine.
1.9) Announce webkit-dev about the transition.
> 2) Flip the global default value and remove port-specific defaults.

[Jesus Sanchez-Palencia]

(In reply to comment #6)
> Does this make sense? If so, I'm going to upload a patch that just changes Qt's default.

I'm fine with it and according to previous comments here I believe the others also are.

[Yuta Kitamura]

Created attachment 131887 [details]
Patch

[Simon Hausmann]

Comment on attachment 131887 [details]
Patch

rs=me

[Yuta Kitamura]

Comment on attachment 131887 [details]
Patch

Thanks!

[WebKit Review Bot]

Comment on attachment 131887 [details]
Patch

Clearing flags on attachment: 131887

Committed r110905: <http://trac.webkit.org/changeset/110905>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.