Summary: | [Chromium] Show placeholder even if the element is focused | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, gordeon, mathias, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 73615 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Kent Tamura
2011-12-01 23:30:39 PST
Created attachment 117578 [details]
Patch
Comment on attachment 117578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117578&action=review > Source/WebCore/ChangeLog:8 > + No new tests. Need to update some existing placeholder tests. Affected tests were already marked as FAIL in http://trac.webkit.org/changeset/101742. > Source/WebCore/rendering/RenderThemeChromiumSkia.h:160 > + int menuListInternalPadding(RenderStyle*, int paddingType) const; > + bool paintMediaButtonInternal(GraphicsContext*, const IntRect&, Image*); > + IntRect convertToPaintingRect(RenderObject* inputRenderer, const RenderObject* partRenderer, IntRect partRect, const IntRect& localOffset) const; > +}; Note: The declaration of RenderThemeChromiumSkia starts at the first column. The current indentation of these functions and '};' are wrong. Comment on attachment 117578 [details] Patch Clearing flags on attachment: 117578 Committed r101848: <http://trac.webkit.org/changeset/101848> All reviewed patches have been landed. Closing bug. |