Bug 73590

Summary:

check-webkit-style doesn't flag JSON syntax errors

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

levin, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

73605

Bug Blocks:

73557

Attachments:

Description	Flags
Patch	darin: review+

Description Adam Roben (:aroben) 2011-12-01 14:26:52 PST

check-webkit-style doesn't flag JSON syntax errors

Comment 1 Adam Roben (:aroben) 2011-12-01 14:27:44 PST

Created attachment 117491 [details]
Patch

Comment 2 David Levin 2011-12-01 14:34:47 PST

Nicely done.

Comment 3 Adam Roben (:aroben) 2011-12-01 14:38:05 PST

Committed r101711: <http://trac.webkit.org/changeset/101711>

Comment 4 Ryosuke Niwa 2011-12-01 17:06:01 PST

It appears that this patch broke 3 python tests:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/35102
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/35102/steps/webkitpy-test/logs/stdio

Comment 5 Ryosuke Niwa 2011-12-01 17:08:21 PST

Reopen the bug because the patch will be rolled out.

Comment 6 Ryosuke Niwa 2011-12-01 17:08:50 PST

I'm rolling out the patch per email discussion with Darin.

Comment 7 Adam Roben (:aroben) 2011-12-02 08:34:10 PST

Committed r101803: <http://trac.webkit.org/changeset/101803>