Bug 73585 – [Chromium] Add a helper method to find whether an html page has custom page size styles.

• Component: CSS
• Status: RESOLVED FIXED

[kmadhusu]

Created attachment 117472 [details]
Patch

Actual bug: crbug.com/85132.

To support my changes to fix crbug.com/85132, I need to add a helper method to identify whether the page has custom page size style.

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Darin Adler]

Comment on attachment 117472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review

> Source/WebCore/dom/Document.cpp:1698
> +    RefPtr<RenderStyle> style = styleForPage(pageIndex);
> +    return style->pageSizeType() != PAGE_SIZE_AUTO;

This function should not be added. You can just put all the code at at the call site in WebFrameImpl.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1481
> +    return frame()->document()->hasCustomPageSizeStyle(pageIndex);

return frame->document()->styleForPage(pageIndex)->pageSizeType() != PAGE_SIZE_AUTO;

[Kent Tamura]

Comment on attachment 117472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review

The patch contains no ChangeLog.

> LayoutTests/printing/page-format-data.html:62
> +        // Page size style tests.

Do you think layoutTestController.hasCustomPageSizeStyle() is Chromium-specific?
If so, we should make a new test in LayoutTests/chromium/printing/ directory.

[Kent Tamura]

(In reply to comment #3)
> (From update of attachment 117472 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=117472&action=review
> 
> The patch contains no ChangeLog.
> 
> > LayoutTests/printing/page-format-data.html:62
> > +        // Page size style tests.
> 
> Do you think layoutTestController.hasCustomPageSizeStyle() is Chromium-specific?
> If so, we should make a new test in LayoutTests/chromium/printing/ directory.

LayoutTests/platform/chromium/printing/

[kmadhusu]

Created attachment 117539 [details]
Patch

Addressed review comments and created a new test.

[Kent Tamura]

Comment on attachment 117539 [details]
Patch

Please add ChangeLog.

[Darin Fisher (:fishd, Google)]

Comment on attachment 117539 [details]
Patch

WebKit API changes LGTM

[kmadhusu]

Created attachment 117639 [details]
Latest patch with Changelog

ChangeLog added.

Thanks.

[kmadhusu]

fishd: Can you commit this patch for me?

Thanks.

[Kent Tamura]

Comment on attachment 117639 [details]
Latest patch with Changelog

Clearing flags on attachment: 117639

Committed r101851: <http://trac.webkit.org/changeset/101851>

[Kent Tamura]

All reviewed patches have been landed.  Closing bug.