Bug 73580 – Rollout r101743

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

As mentioned in https://bugs.webkit.org/show_bug.cgi?id=73111#c25, linking of the Tools/ targets (EWebLauncher, DumpRenderTree and ImageDiff) is broken with r101347:

  ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::uidForImage(WebCore::Image*)'
  ../../../Source/WebCore/libwebcore_efl.so.0.1.0: undefined reference to `WebCore::BGRA32PremultimpliedBuffer::create()'
collect2: ld returned 1 exit status

These functions are implemented in TextureMapperQt.cpp. Alternatively, one might be interested in sharing TextureMapperCairo with GTK+ (it got committed not long ago).

[Raphael Kubo da Costa (:rakuco)]

Created attachment 117455 [details]
Patch

[WebKit Review Bot]

Comment on attachment 117455 [details]
Patch

Rejecting attachment 117455 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
- saving rejects to file Source/WebCore/platform/graphics/GraphicsLayer.h.rej
patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.cpp
patching file Source/WebCore/platform/graphics/efl/GraphicsLayerEfl.h
patching file Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp
patching file Source/cmake/OptionsEfl.cmake
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10727124

[Raphael Kubo da Costa (:rakuco)]

Created attachment 117614 [details]
Rebased patch for landing

[WebKit Review Bot]

Comment on attachment 117614 [details]
Rebased patch for landing

Clearing flags on attachment: 117614

Committed r101796: <http://trac.webkit.org/changeset/101796>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.