Bug 73568

Summary: StyledElement: Clean up inline style accessors.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2011-12-01 09:38:40 PST
The difference between inlineStyleDecl() and getInlineStyleDecl() is way too subtle. I suggest we rename getInlineStyleDecl() to ensureInlineStyleDecl(). Call sites should also store the return value in a CSSInlineStyleDeclaration*. Furthermore, we should make StyledElement::style() explicitly virtual and decorate it with OVERRIDE.
Attachments
Patch (22.26 KB, patch)
2011-12-01 10:45 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-12-01 10:45:21 PST
Created attachment 117443 [details] Patch
WebKit Review Bot
Comment 2 2011-12-01 14:22:58 PST
Comment on attachment 117443 [details] Patch Clearing flags on attachment: 117443 Committed r101707: <http://trac.webkit.org/changeset/101707>
WebKit Review Bot
Comment 3 2011-12-01 14:23:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.