Bug 73553

Summary: eliminate find_test_files from Port class
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Tools / TestsAssignee: Ilya Tikhonovsky <loislo>
Status: REOPENED    
Severity: Normal CC: abarth, dpranke, eric, rniwa, roger_fong, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=254273
Attachments:
Description Flags
Patch
none
Patch dpranke: review+

Ilya Tikhonovsky
Reported 2011-12-01 04:37:13 PST
rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests() I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files. Also I'll move static functions close to their usage.
Attachments
Patch (17.86 KB, patch)
2011-12-01 04:49 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (17.78 KB, patch)
2011-12-01 05:05 PST, Ilya Tikhonovsky 		dpranke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2011-12-01 04:49:14 PST
Created attachment 117400 [details] Patch
Ilya Tikhonovsky
Comment 2 2011-12-01 05:05:37 PST
Created attachment 117401 [details] Patch
Dirk Pranke
Comment 3 2011-12-01 14:03:05 PST
adding rniwa to this since he has also been hacking on port.tests() and reftest-related changes.
Ilya Tikhonovsky
Comment 4 2011-12-02 00:44:36 PST
Committed r101757: <http://trac.webkit.org/changeset/101757>
Roger Fong
Comment 5 2012-12-12 16:34:44 PST
Just ran across this today: Something seems amiss in base.py. 520 def is_reference_html_file(filesystem, dirname, filename): 521 if filename.startswith('ref-') or filename.endswith('notref-'): 522 return True First off, it seems weird that we're using prefixes instead of suffixes. Seems like that wouldn't work so well given that all the test names are given meaning and could being with ref- arbitrarily. Secondly, endsWith(notref-') ? That seems a little off as well...
Dirk Pranke
Comment 6 2012-12-12 16:38:56 PST
ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though. Are you finding any existing tests that do start with ref- that would cause a problem?
Roger Fong
Comment 7 2012-12-12 16:43:17 PST
(In reply to comment #6) > ref- and notref- prefixes come from the w3c's naming conventions. I think you're correct about the endswith being a problem, though. I'll go ahead and fix that up then. > Are you finding any existing tests that do start with ref- that would cause a problem? I don't see any no. Just thinking it might be a concern in the future...
Note You need to log in before you can comment on or make changes to this bug.