Bug 73511

Summary:

Internals should have a method to return the max sequence number of spellcheck request.

Product:

WebKit

Reporter:

Shinya Kawanaka <shinyak>

Component:

HTML Editing

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dominicc, gustavo, morrita, shinyak, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

72942

Attachments:

Description	Flags
Test Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Shinya Kawanaka

Reported 2011-11-30 18:53:22 PST

This is required to create a test for: https://bugs.webkit.org/show_bug.cgi?id=72942

Attachments
Test Patch (3.98 KB, patch) 2011-11-30 21:52 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (6.61 KB, patch) 2011-12-01 22:37 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (12.34 KB, patch) 2011-12-06 01:09 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (12.58 KB, patch) 2011-12-06 17:54 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (13.86 KB, patch) 2011-12-06 18:16 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Patch (13.86 KB, patch) 2011-12-07 03:04 PST, Shinya Kawanaka	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2011-11-30 21:52:39 PST

Created attachment 117333 [details] Test Patch

Early Warning System Bot

Comment 2 2011-11-30 21:56:21 PST

Comment on attachment 117333 [details] Test Patch Attachment 117333 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10689172

WebKit Review Bot

Comment 3 2011-12-01 01:11:43 PST

Comment on attachment 117333 [details] Test Patch Attachment 117333 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10697538

Gustavo Noronha (kov)

Comment 4 2011-12-01 14:07:17 PST

Comment on attachment 117333 [details] Test Patch Attachment 117333 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10709739

Shinya Kawanaka

Comment 5 2011-12-01 22:37:24 PST

Created attachment 117570 [details] Patch

WebKit Review Bot

Comment 6 2011-12-01 22:54:50 PST

Comment on attachment 117570 [details] Patch Attachment 117570 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10725239

Shinya Kawanaka

Comment 7 2011-12-06 01:09:22 PST

Created attachment 118005 [details] Patch

Hajime Morrita

Comment 8 2011-12-06 03:58:08 PST

Comment on attachment 118005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118005&action=review Basically looks nice. I pointed some nits. > Source/WebCore/testing/Internals.cpp:624 > + if (!document || !document->frame() || !document->frame()->editor() || !document->frame()->editor()->spellChecker()) { Could you add a getter for spellchecker like Internals::spellchecker()? > LayoutTests/ChangeLog:8 > + Tests to check internals.lastSpellCheckRequestSequence and internals.lastSpellCheckProcessedSequence. "Added tests"? > LayoutTests/ChangeLog:12 > + I guess we need to skip on some ports. You will know which ports do ;-) > LayoutTests/editing/spelling/spellcheck-sequencenum.html:111 > + testPassed("SpellCheck sequence seems work correctly."); "seems working"?

Shinya Kawanaka

Comment 9 2011-12-06 17:54:01 PST

Created attachment 118151 [details] Patch

Shinya Kawanaka

Comment 10 2011-12-06 18:16:51 PST

Created attachment 118155 [details] Patch

Dominic Cooney

Comment 11 2011-12-06 18:17:49 PST

Please remember to update <http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree> when this lands to document the API you are adding to window.internals.

WebKit Review Bot

Comment 12 2011-12-06 20:08:02 PST

Comment on attachment 118155 [details] Patch Attachment 118155 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10747018