Bug 73501

Summary: StyledElement: Tidy up copyNonAttributeProperties().
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, koivisto: commit-queue-

Andreas Kling
Reported 2011-11-30 16:58:44 PST
As a follow-up to bug 73227 (landed in r101502), we should tidy up copyNonAttributeProperties() a bit, redo CSSMutableStyleDeclaration's copyPropertiesAndStrictnessFrom() as copyPropertiesFrom(), and make the style declarations non-copyable.
Attachments
Patch (5.63 KB, patch)
2011-11-30 17:05 PST, Andreas Kling 		koivisto: review+
koivisto: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-11-30 17:05:07 PST
Created attachment 117301 [details] Patch
Antti Koivisto
Comment 2 2011-12-01 02:29:52 PST
Comment on attachment 117301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117301&action=review > Source/WebCore/css/CSSInlineStyleDeclaration.h:35 > class CSSInlineStyleDeclaration : public CSSElementStyleDeclaration { > + WTF_MAKE_NONCOPYABLE(CSSInlineStyleDeclaration); I think it is sufficient to have this in the base class (some other instances here too).
Andreas Kling
Comment 3 2011-12-01 07:20:13 PST
Committed r101665: <http://trac.webkit.org/changeset/101665>
Note You need to log in before you can comment on or make changes to this bug.