Bug 73496

Summary: Replace a custom constructor of window.Audio with the [NamedConstructor] IDL
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dominicc, ojan, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73521    
Bug Blocks: 71093    
Attachments:
Description Flags
Patch
none
patch for commit
none
Patch none

Kentaro Hara
Reported 2011-11-30 16:18:09 PST
We can remove JSAudioConstructor.{h,cpp}. We can generate the constructors of window.Audio by the [NamedConstructor] IDL.
Attachments
Patch (14.89 KB, patch)
2011-11-30 16:27 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for commit (22.22 KB, patch)
2011-11-30 16:56 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (23.78 KB, patch)
2011-12-01 01:25 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-11-30 16:27:15 PST
Created attachment 117292 [details] Patch
Early Warning System Bot
Comment 2 2011-11-30 16:37:00 PST
Comment on attachment 117292 [details] Patch Attachment 117292 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10704341
Adam Barth
Comment 3 2011-11-30 16:44:49 PST
(Assuming it compiles.)
Kentaro Hara
Comment 4 2011-11-30 16:45:47 PST
We need to remove all "JSAudioConstructor.{h.cpp}" from all build scripts. After that I'll commit it. Thanks.
Kentaro Hara
Comment 5 2011-11-30 16:56:43 PST
Created attachment 117298 [details] patch for commit
Kentaro Hara
Comment 6 2011-12-01 01:25:36 PST
Created attachment 117376 [details] Patch
Kentaro Hara
Comment 7 2011-12-01 01:26:57 PST
Adam: I've made a non-trivial change since your first review. Would you please take another look at it?
Adam Barth
Comment 8 2011-12-01 11:34:59 PST
Comment on attachment 117376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117376&action=review > LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt:-45 > -window.Audio.length [number] Strange. I wonder why this used to be there. Certainly looks like a progression. Will this cause test failures on other ports? (This file has a lot of port-specific expected results.)
WebKit Review Bot
Comment 9 2011-12-01 16:59:35 PST
Comment on attachment 117376 [details] Patch Clearing flags on attachment: 117376 Committed r101723: <http://trac.webkit.org/changeset/101723>
WebKit Review Bot
Comment 10 2011-12-01 16:59:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.