| Summary: | Enable web audio by default on non-Mac POSIX platforms | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | chromium | ||||
| Component: | Web Audio | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, crogers, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
chromium
2011-11-30 14:09:55 PST
Build web audio by default on new Unix platforms, this patch has been used to build web audio on FreeBSD, Solaris, OpenBSD, and NetBSD. I tested the Drum Machine web audio demo on FreeBSD and it appears to work fine. Created attachment 117275 [details]
enable web audio on unix
Please review: Chris - OK inclusion of other UNIX platforms for web audio Adam - Confirm Android exclusion Tony - Any additional input Seems fine to me. Excluding android is fine. It looks like Chris is on vacation and won't get to this soon, but I'd like this patch to get into Chromium before the final 17.0 branch. Perhaps Tony can commit this and Chris can revert later if he disagrees? I doubt Chris will care about these other POSIX platforms since nothing changes for the main platforms with this patch, just thought I'd get his stamp since he's the web audio guy. Comment on attachment 117275 [details]
enable web audio on unix
I agree, this seems harmless.
Comment on attachment 117275 [details] enable web audio on unix Clearing flags on attachment: 117275 Committed r102178: <http://trac.webkit.org/changeset/102178> All reviewed patches have been landed. Closing bug. |