Bug 73491

Summary: Enable web audio by default on non-Mac POSIX platforms
Product: WebKit Reporter: chromium
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, crogers, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
enable web audio on unix none

chromium
Reported 2011-11-30 14:09:55 PST
enable web audio by default on non-Mac POSIX platforms
Attachments
enable web audio on unix (2.51 KB, patch)
2011-11-30 14:29 PST, chromium 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chromium
Comment 1 2011-11-30 14:26:07 PST
Build web audio by default on new Unix platforms, this patch has been used to build web audio on FreeBSD, Solaris, OpenBSD, and NetBSD. I tested the Drum Machine web audio demo on FreeBSD and it appears to work fine.
chromium
Comment 2 2011-11-30 14:29:58 PST
Created attachment 117275 [details] enable web audio on unix
chromium
Comment 3 2011-11-30 14:34:39 PST
Please review: Chris - OK inclusion of other UNIX platforms for web audio Adam - Confirm Android exclusion Tony - Any additional input
Tony Chang
Comment 4 2011-11-30 14:41:03 PST
Seems fine to me.
Adam Barth
Comment 5 2011-11-30 14:47:44 PST
Excluding android is fine.
chromium
Comment 6 2011-12-06 13:15:13 PST
It looks like Chris is on vacation and won't get to this soon, but I'd like this patch to get into Chromium before the final 17.0 branch. Perhaps Tony can commit this and Chris can revert later if he disagrees? I doubt Chris will care about these other POSIX platforms since nothing changes for the main platforms with this patch, just thought I'd get his stamp since he's the web audio guy.
Tony Chang
Comment 7 2011-12-06 13:20:50 PST
Comment on attachment 117275 [details] enable web audio on unix I agree, this seems harmless.
WebKit Review Bot
Comment 8 2011-12-06 14:07:16 PST
Comment on attachment 117275 [details] enable web audio on unix Clearing flags on attachment: 117275 Committed r102178: <http://trac.webkit.org/changeset/102178>
WebKit Review Bot
Comment 9 2011-12-06 14:07:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.