Bug 73491 - Enable web audio by default on non-Mac POSIX platforms
Summary: Enable web audio by default on non-Mac POSIX platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 14:09 PST by chromium
Modified: 2011-12-06 14:07 PST (History)
4 users (show)

See Also:

Attachments
enable web audio on unix (2.51 KB, patch)
2011-11-30 14:29 PST, chromium 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chromium 2011-11-30 14:09:55 PST 
enable web audio by default on non-Mac POSIX platforms
Comment 1 chromium 2011-11-30 14:26:07 PST 
Build web audio by default on new Unix platforms, this patch has been used to build web audio on FreeBSD, Solaris, OpenBSD, and NetBSD.  I tested the Drum Machine web audio demo on FreeBSD and it appears to work fine.
Comment 2 chromium 2011-11-30 14:29:58 PST 
Created attachment 117275 [details]
enable web audio on unix
Comment 3 chromium 2011-11-30 14:34:39 PST 
Please review:

Chris - OK inclusion of other UNIX platforms for web audio
Adam  - Confirm Android exclusion
Tony  - Any additional input
Comment 4 Tony Chang 2011-11-30 14:41:03 PST 
Seems fine to me.
Comment 5 Adam Barth 2011-11-30 14:47:44 PST 
Excluding android is fine.
Comment 6 chromium 2011-12-06 13:15:13 PST 
It looks like Chris is on vacation and won't get to this soon, but I'd like this patch to get into Chromium before the final 17.0 branch.  Perhaps Tony can commit this and Chris can revert later if he disagrees?  I doubt Chris will care about these other POSIX platforms since nothing changes for the main platforms with this patch, just thought I'd get his stamp since he's the web audio guy.
Comment 7 Tony Chang 2011-12-06 13:20:50 PST 
Comment on attachment 117275 [details]
enable web audio on unix

I agree, this seems harmless.
Comment 8 WebKit Review Bot 2011-12-06 14:07:16 PST 
Comment on attachment 117275 [details]
enable web audio on unix

Clearing flags on attachment: 117275

Committed r102178: <http://trac.webkit.org/changeset/102178>
Comment 9 WebKit Review Bot 2011-12-06 14:07:21 PST 
All reviewed patches have been landed.  Closing bug.