Summary: | [GTK] Add freetype to our jhbuild setup | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gustavo Noronha (kov) <gustavo> | ||||||||||
Component: | New Bugs | Assignee: | Gustavo Noronha (kov) <gustavo> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gustavo, mrobinson, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Gustavo Noronha (kov)
2011-11-30 13:56:23 PST
Created attachment 117267 [details]
Patch
This is a small first step. TODO: - add a check to run autogen if the md5sum of jhbuildrc or jhbuild.modules changes - also call update-webkitgtk-libs in the EWS Comment on attachment 117267 [details] Patch Attachment 117267 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10709673 Created attachment 117439 [details]
Patch
Created attachment 117458 [details]
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=117439&action=review > Tools/Scripts/webkitdirs.pm:1576 > +sub hashFile($) Perhaps this could be getMD5HashForFile? > Tools/Scripts/webkitdirs.pm:1582 > + # read the whole file Minor nit: Missing capital and period. > Tools/Scripts/webkitdirs.pm:1600 > + # save md5sum for jhbuild-related files Nit: Period and comma again. > Tools/Scripts/webkitdirs.pm:1604 > + saveSum("$file" . ".md5sum", $currentSum); I don't think you need quotations around $file here. > Tools/Scripts/webkitdirs.pm:1626 > +sub mustRunAutogen($@) Perhaps mustRerunAutogen? Might be slightly clearer. Either way is likely fine though. Created attachment 117488 [details]
Patch
Comment on attachment 117488 [details] Patch Clearing flags on attachment: 117488 Committed r101708: <http://trac.webkit.org/changeset/101708> All reviewed patches have been landed. Closing bug. |