Bug 73487

Summary: [GTK] Read fonts from the jhbuild root
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gustavo, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73473    
Bug Blocks: 73423    
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2011-11-30 13:53:38 PST
Instead of trying to read fonts from the system, we should read them from the jhbuild root. This is the first step toward requiring jhbuild to run tests.
Attachments
Patch (9.45 KB, patch)
2011-11-30 13:58 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (12.17 KB, patch)
2011-12-01 10:17 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-11-30 13:58:13 PST
Created attachment 117268 [details] Patch
Gustavo Noronha (kov)
Comment 2 2011-12-01 01:33:17 PST
Comment on attachment 117268 [details] Patch LGTM, wonder if it wouldn't be better to fallback to the well-known directory in case WEBKIT_TEST_FONTS is not set, though, since it would be easier when running DRT manually for debugging purposes, what do you think?
Martin Robinson
Comment 3 2011-12-01 10:17:26 PST
Created attachment 117442 [details] Patch
Martin Robinson
Comment 4 2011-12-01 14:45:32 PST
Committed r101712: <http://trac.webkit.org/changeset/101712>
Note You need to log in before you can comment on or make changes to this bug.