Bug 73487 - [GTK] Read fonts from the jhbuild root
Summary: [GTK] Read fonts from the jhbuild root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on: 73473
Blocks: 73423
  Show dependency treegraph
 
Reported: 2011-11-30 13:53 PST by Martin Robinson
Modified: 2011-12-01 14:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.45 KB, patch)
2011-11-30 13:58 PST, Martin Robinson
no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2011-12-01 10:17 PST, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-11-30 13:53:38 PST
Instead of trying to read fonts from the system, we should read them from the jhbuild root. This is the first step toward requiring jhbuild to run tests.
Comment 1 Martin Robinson 2011-11-30 13:58:13 PST
Created attachment 117268 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2011-12-01 01:33:17 PST
Comment on attachment 117268 [details]
Patch

LGTM, wonder if it wouldn't be better to fallback to the well-known directory in case WEBKIT_TEST_FONTS is not set, though, since it would be easier when running DRT manually for debugging purposes, what do you think?
Comment 3 Martin Robinson 2011-12-01 10:17:26 PST
Created attachment 117442 [details]
Patch
Comment 4 Martin Robinson 2011-12-01 14:45:32 PST
Committed r101712: <http://trac.webkit.org/changeset/101712>