Bug 73477

Summary: Prepare to deploy pass and peek types in the HashMap class
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72474    
Attachments:
Description Flags
Patch
none
Patch aroben: review+

Darin Adler
Reported 2011-11-30 11:55:05 PST
Prepare to deploy pass and peek types in the HashMap class
Attachments
Patch (26.27 KB, patch)
2011-11-30 12:07 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (57.64 KB, patch)
2011-12-01 20:22 PST, Darin Adler 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-11-30 12:07:48 PST
Created attachment 117244 [details] Patch
Geoffrey Garen
Comment 2 2011-11-30 12:13:36 PST
Comment on attachment 117244 [details] Patch r=me
Darin Adler
Comment 3 2011-11-30 12:35:52 PST
Looks like there is some kind of compilation problem with gcc 4.2 so I can’t land this yet. Anders, any ideas?
Darin Adler
Comment 4 2011-12-01 20:22:26 PST
Created attachment 117552 [details] Patch
WebKit Review Bot
Comment 5 2011-12-01 20:25:32 PST
Attachment 117552 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/HashSet.h:29: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 6 2011-12-02 08:38:05 PST
Comment on attachment 117552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117552&action=review > Source/JavaScriptCore/wtf/HashSet.h:73 > + // FIXME: We should reverse the order of the template arguments so that callers > + // can just pass the translator let the compiler deduce T. I think you're missing a word in there. > Source/JavaScriptCore/wtf/HashSet.h:88 > + // FIXME: We should reverse the order of the template arguments so that callers > + // can just pass the translator let the compiler deduce T. Ditto.
Darin Adler
Comment 7 2011-12-02 08:50:38 PST
Committed r101806: <http://trac.webkit.org/changeset/101806>
Note You need to log in before you can comment on or make changes to this bug.