Bug 73470

Summary: Add tests for RetainPtr::adoptNS/adoptCF
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch darin: review+

Sam Weinig
Reported 2011-11-30 10:58:10 PST
Add tests for RetainPtr::adoptNS/adoptCF
Attachments
Patch (9.53 KB, patch)
2011-11-30 10:59 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.56 KB, patch)
2011-12-02 18:32 PST, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-11-30 10:59:13 PST
Created attachment 117223 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-11-30 11:00:13 PST
Comment on attachment 117223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117223&action=review > Tools/ChangeLog:8 > + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: And .vcproj plz! > Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:39 > + EXPECT_EQ(1, CFGetRetainCount(foo.get())); Would -retainCount be better?
Sam Weinig
Comment 3 2011-11-30 17:07:38 PST
(In reply to comment #2) > (From update of attachment 117223 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=117223&action=review > > > Tools/ChangeLog:8 > > + * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: > > And .vcproj plz! Ok. > > Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:39 > > + EXPECT_EQ(1, CFGetRetainCount(foo.get())); > > Would -retainCount be better? Not really, especially since we use CFRetain internally on these objects.
Sam Weinig
Comment 4 2011-12-02 18:32:51 PST
Created attachment 117730 [details] Patch
Sam Weinig
Comment 5 2011-12-04 13:26:18 PST
Committed revision 101965
Note You need to log in before you can comment on or make changes to this bug.