Bug 7345

Summary: add insert and remove functions to KXMLCore::Vector
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 7331    
Attachments:
Description Flags
implementation of insert and remove mjs: review+

Darin Adler
Reported 2006-02-18 14:46:30 PST
I came across yet another place where I needed insert and remove in a vector, so I wrote them as discussed with Maciej previously.
Attachments
implementation of insert and remove (4.53 KB, patch)
2006-02-18 14:48 PST, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2006-02-18 14:48:21 PST
Created attachment 6591 [details] implementation of insert and remove
Maciej Stachowiak
Comment 2 2006-02-18 15:02:58 PST
Comment on attachment 6591 [details] implementation of insert and remove The ASSERT in remove() should be <, not <=. Other than that, r=me.
Note You need to log in before you can comment on or make changes to this bug.